Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

West-Midlands ITP-Jan-2025 | Ifeanyi Madubugwu | Module-Data-Group | Sprint -3| alarm-clock #453

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Elchacode
Copy link

Learners, PR Template

Self checklist

  • [x ] I have committed my files one by one, on purpose, and for a reason
  • [x ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ x] I have tested my changes
  • [x ] My changes follow the style guide
  • [x ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Elchacode Elchacode added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Participant to add when requesting review labels Mar 29, 2025
@prabhveer-mujral prabhveer-mujral added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 4, 2025
const alarmTimeInput = parseInt(typedInput.value); // Getting the value from the input field and converting it to an integer
if (isNaN(alarmTimeInput) || alarmTimeInput <= 0) {
// Checking if the value is not a number or less than 0
alert("Please enter a valid number"); // Displaying an alert message if the value is not a number or less than 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice validation

@prabhveer-mujral
Copy link

Overall good work, I like the changes such as the background colour changing.

@Elchacode Elchacode added the Complete Participant to add when work is complete and review comments have been addressed label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complete Participant to add when work is complete and review comments have been addressed Reviewed Volunteer to add when completing a review 📅 Sprint 3 Assigned during Sprint 3 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants